Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup names and comments #1443

Merged

Conversation

wulfraem
Copy link
Contributor

Description of change

PR cleans up some comments and names in the code.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Ran tests locally.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wulfraem wulfraem added Documentation Improvements or additions to documentation. Excludes from changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Nov 25, 2024
@wulfraem wulfraem requested a review from a team as a code owner November 25, 2024 15:19
@wulfraem wulfraem added No changelog Excludes PR from becoming part of any changelog and removed Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Nov 25, 2024
@UMR1352
Copy link
Contributor

UMR1352 commented Nov 26, 2024

I'll install a word checking extension 🙏

@wulfraem
Copy link
Contributor Author

I'll install a word checking extension 🙏

In my opinion, these typos come from actually documenting something, which is never a bad thing, and am 100% happy about it. ^^

Just double-checked the files. :D

@wulfraem wulfraem merged commit 53b8117 into feat/identity-rebased-alpha Nov 26, 2024
6 checks passed
@wulfraem wulfraem self-assigned this Nov 28, 2024
@wulfraem wulfraem deleted the feat/cleanup-names-and-comments branch March 5, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation. Excludes from changelog No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants