Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Transaction handling for WASM on testnet #1587

Merged

Conversation

wulfraem
Copy link
Contributor

@wulfraem wulfraem commented Mar 5, 2025

Description of change

Fixes issues with Fix Transaction handling for WASM on testnet:

  • testnet faucet only returns one coin, so coin lookup had to be updated, now works basically the same as the lookup in Rust.
  • A gas budget can now be set when creating identities and/or when updating DID documents. Similar to proposal, gas budget can be set with with_gas_budget function or with gasBudget setter on transaction.
  • Default gas budget in WASM transaction has been lowered to usual value of 50_000_000.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tested local to local, and from local to testnet. For overall validation, waiting for CI.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

wulfraem added 3 commits March 5, 2025 15:09
…x`, lower default gas budget to 10000000000
- now checks balances and pages through coins instead of only taking the second coin
- align error messages between Rust and TypeScript
- reduces from 50_000_000 to 10_000_000
@wulfraem wulfraem added Bug Something isn't working. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Mar 5, 2025
@wulfraem wulfraem requested a review from a team as a code owner March 5, 2025 15:35
@wulfraem wulfraem added Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog and removed Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Mar 5, 2025
@wulfraem wulfraem merged commit e50ac26 into feat/identity-rebased-alpha Mar 6, 2025
13 checks passed
@wulfraem wulfraem deleted the feat/fix-tx-handling-for-wasm-on-testnet branch March 6, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants