Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pre-commit.ci with github workflows #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace pre-commit.ci with github workflows #20

wants to merge 1 commit into from

Conversation

GreatAlexander
Copy link
Member

  • More maintainable and less overbearing than pre-commit.ci
  • Runs pre-commit on every pull-request based on config
  • Updates pre-commit hook versions periodically (2nd day of the month)
  • Remove ci params from pre-commit config
  • No automatic merging by mergify, it's now done by github
  • No merge_protections by mergify, it's now done by github

@GreatAlexander
Replace pre-commit.ci with github workflows
c65bedf 
 - More maintainable and less overbearing than pre-commit.ci
 - Runs pre-commit on every pull-request based on config
 - Updates pre-commit hook versions periodically (2nd day of the month)
 - Remove ci params from pre-commit config
 - No automatic merging by mergify, it's now done by github
 - No merge_protections by mergify, it's now done by github
@mergify mergify bot requested a review from hect95 March 18, 2025 18:44
@mergify Mergify
Copy link

mergify bot commented Mar 18, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require approval

This rule is failing.

Require at least one review approval before merging is allowed (If not a pre-commit PR)

  • #approved-reviews-by >= 1

🟢 📃 Configuration Change Requirements

Wonderful, this rule succeeded.

Mergify configuration change

  • check-success = Configuration changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hect95 hect95 Awaiting requested review from hect95

Assignees

@GreatAlexander GreatAlexander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GreatAlexander