Implement CAR CID iterator and supplier #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 60.05% 62.02% +1.97%
==========================================
Files 9 12 +3
Lines 393 553 +160
==========================================
+ Hits 236 343 +107
- Misses 119 158 +39
- Partials 38 52 +14
Continue to review full report at Codecov.
|
masih
force-pushed
the
masih/car-cid-supplier
branch
2 times, most recently
from
9b98e4c to
a985872
Compare
|
this appears to be fully within the |
My rationale is to keep it internal until it's iterated over and baked in. Then expose as public API as needed. Happy to move now if you think that makes things clearer. |
willscott
reviewed
Aug 26, 2021
adlrocha
reviewed
Aug 27, 2021
adlrocha
reviewed
Aug 27, 2021
masih
force-pushed
the
masih/car-cid-supplier
branch
from
a985872 to
08d4a5e
Compare
willscott
approved these changes
Aug 30, 2021
masih
force-pushed
the
masih/car-cid-supplier
branch
from
5878492 to
fad4928
Compare
masih
force-pushed
the
masih/car-cid-supplier
branch
from
fad4928 to
077ff12
Compare
Implements mechanisms to list the CIDs given a CAR path, regardless of the CAR's version. The mechanism allows paths to be put and removed, and supplies CID iterators given a CAR ID. Implement mechanism to generate CID IDs for a CAR file, regardless of its version. Implement a CID iterator reader that given a CID iterator and a marshaller converts it into a stream of bytes as an `io.ReadCloser`. Implement tests using sample CAR files in versions 1 and 2. Run `gofumpt -l -w .` across the whole repo for consistent formatting. Leave TODOs on undecided or improvable implementations to contain the PR scope. Increase test timeout flaky engine tests.
masih
force-pushed
the
masih/car-cid-supplier
branch
from
077ff12 to
5abea20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements mechanisms to list the CIDs given a CAR path, regardless of
the CAR's version. The mechanism allows paths to be put and removed, and
supplies CID iterators given a CAR ID.
Implement mechanism to generate CID IDs for a CAR file, regardless of
its version.
Implement a CID iterator reader that given a CID iterator and a
marshaller converts it into a stream of bytes as an
io.ReadCloser.Implement tests using sample CAR files in versions 1 and 2.
Run
gofumpt -l -w .across the whole repo for consistent formatting.Leave TODOs on undecided or improvable implementations to contain the PR
scope.
Increase test timeout in flaky engine tests.