Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Button #140

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Daniel-Amadeus
Copy link

I added an optional "Move Button" to move chores/tasks by a configured number of days in the future.

@karwosts
Copy link
Collaborator

Couple thoughts:

  • Clicking the button currently hides the chore/item, which I don't think makes sense. I see the code was copy pasted from the way that completing a chore hides it, but I'm not sure why you would want this for moving. I'd like to see instant visual feedback of the new date.
  • This worked for a task, but when I click a chore, I get unknown_error - response[400] from grocy for the service call.
  • The behavior was not what I expected. I thought that the button would advance the chore due date by the number of days specified, but it actually just sets it to a fixed date based the time from now, not the time it was originally due. So if my move_days is 1, and my task is due in three days, I expected it would move it one day in the future (4 days away), but instead it makes it due tomorrow. Not sure if that's right or wrong, but I did not expect that.

Overall I'm not sure this is the best way to handle this, but if it's an optional button I guess its not hurting anybody.

I'm thinking maybe something that would be better to allow user to move the due date would be to just make the existing due_date label clickable, and when you click it it opens the ha-date-picker (similar to the add task date field), and you can select a date on the calendar, and then submitting that would change the date.

Copy link
Collaborator

@karwosts karwosts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comment in main thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants