Fix for Issue #163 and #164 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to fix the issues i mentioned myself. Code for Custom sort is modified with the help of ChatGPT. And the code to add task category while creating a new task is put together from various other parts of the existing code. Might need a bit of cleanup. Kindly review this. Everything seems to be working in my testing. The only thing i currently have doubt is: - When there is no task category in grocy. (The select dropdown for category will be blank. Hopefully that doesn't cause any errors). If someone can test that please.
This was
linked to
issues
Jan 23, 2025
|
Since the test passes I will release, and then others can test too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix the issues i mentioned myself.
Code for Custom sort is modified with the help of ChatGPT. And the code to add task category while creating a new task is put together from various other parts of the existing code.
Might need a bit of cleanup.
Kindly review this.
Everything seems to be working in my testing.
The only thing i currently have doubt is: