[policy]: make CFeeRate work with uint64_t sizes

Co-authored-by: Pieter Wuille <bitcoin-dev@wuille.net>
ismaelsadeeq · Jul 3, 2024 · 550a6c2 · 550a6c2
1 parent 3714692
commit 550a6c2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/policy/feerate.cpp b/src/policy/feerate.cpp
@@ -9,9 +9,9 @@
 
 #include <cmath>
 
-CFeeRate::CFeeRate(const CAmount& nFeePaid, uint32_t num_bytes)
+CFeeRate::CFeeRate(const CAmount& nFeePaid, uint64_t num_bytes)
 {
-    const int64_t nSize{num_bytes};
+    const int64_t nSize{static_cast<int64_t>(num_bytes)};
 
     if (nSize > 0) {
         nSatoshisPerK = nFeePaid * 1000 / nSize;
@@ -20,9 +20,9 @@ CFeeRate::CFeeRate(const CAmount& nFeePaid, uint32_t num_bytes)
     }
 }
 
-CAmount CFeeRate::GetFee(uint32_t num_bytes) const
+CAmount CFeeRate::GetFee(uint64_t num_bytes) const
 {
-    const int64_t nSize{num_bytes};
+    const int64_t nSize{static_cast<int64_t>(num_bytes)};
 
     // Be explicit that we're converting from a double to int64_t (CAmount) here.
     // We've previously had issues with the silent double->int64_t conversion.

diff --git a/src/policy/feerate.h b/src/policy/feerate.h
@@ -50,14 +50,14 @@ class CFeeRate
      * param@[in]   nFeePaid    The fee paid by a transaction, in satoshis
      * param@[in]   num_bytes   The vsize of a transaction, in vbytes
      */
-    CFeeRate(const CAmount& nFeePaid, uint32_t num_bytes);
+    CFeeRate(const CAmount& nFeePaid, uint64_t num_bytes);
 
     /**
      * Return the fee in satoshis for the given vsize in vbytes.
      * If the calculated fee would have fractional satoshis, then the
      * returned fee will always be rounded up to the nearest satoshi.
      */
-    CAmount GetFee(uint32_t num_bytes) const;
+    CAmount GetFee(uint64_t num_bytes) const;
 
     /**
      * Return the fee in satoshis for a vsize of 1000 vbytes