-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actually update branched image tag in all jobs, not just parent config #5592
Open
mikemorris
wants to merge
4
commits into
istio:master
Choose a base branch
from
mikemorris:update-branched-image-jobs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+88
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Jan 31, 2025
/hold Going to add the duplicate env removal on top of this since it's now actually iterating over all jobs. |
istio-testing
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Jan 31, 2025
/unhold Tested locally and this appears to be working as intended now. |
mikemorris
added a commit
that referenced
this pull request
Jan 31, 2025
I believe this is the last part of step 3 (aside from Google Artifact Registry image tagging) that must still be done manually after updates in #5592 and istio/release-builder#2026 I'm guessing an updated version of the automation PR should be merged before this. /hold
kfaseela
approved these changes
Jan 31, 2025
@mikemorris : this LGTM. I just added a hold in case you have anything else to verify or want @howardjohn to do a review before merging. Feel free to remove the dnm when you want to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do-not-merge
Block automatic merging of a PR.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be an oversight where the image was not being updated to the branched tag in all jobs, only in the parent config. I believe this should replace the need for the following manual part of Step 3 as described in istio/istio#54707
Additionally, filters out duplicate env vars in all jobs to replace the need for the following other manual part of Step 3,
refs https://pkg.go.dev/k8s.io/api/core/v1#EnvVar
Finally, adds logging for commands needed to retag images when running with
--skip-gar-tagging
and updates some minor deprecated filesystem calls./cc @kfaseela @dhawton