Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a interface-difference and two bugs in LBA.jl:
instead of specifing Δt like in other functions (e.g. DDM), one specifies the number of timesteps.
But this number was not actually used to evaluate the evidence, thus resulting in a missmatch between the timesteps and the evidence.
one
rand
function didnt use the rng-objectThis might be judged as breaking because of interface change, maybe a wrapper is possible? But at least the bug should be fixed in anycase.
Best, Timo & @behinger
PS: Note that we havent tested the fix yet locally🙈