[Docs] Minor typos #62
Conversation
|
By the way, what do you think about making the Wald & Exgauss compatible with a specification of type:
i.e., accepting a vector of length 1 for drift/sigma? I think it might add the (small) benefit of being able to have a consistent syntax accross models in Turing (i.e., using filldist and vectorized operations) with other models. |
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 89.97% 89.97%
=======================================
Files 23 23
Lines 1416 1416
=======================================
Hits 1274 1274
Misses 142 142 ☔ View full report in Codecov by Sentry. |
docs/src/lca.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Leaky Competing Accumulator | |||
|
|
|||
| The Leaky Competing Accumulator (LCA; Usher & McClelland, 2001) is a sequential sampling model in which evidence for options races independently. The LBA makes an additional simplification that evidence accumulates in a linear and ballistic fashion, meaning there is no intra-trial noise. Instead, evidence accumulates deterministically and linearly until it hits the threshold. | |||
| The Leaky Competing Accumulator (LCA; Usher & McClelland, 2001) is a sequential sampling model in which evidence for options races independently. the LCA is similar to the Linear Ballistic Accumulator (LBA), but additionally assumes an intra-trial noise in the form of evidence accumulation leakage (in contrast, the The LBA assumes that evidence accumulates in a ballistic fashion, i.e., linearly and deterministically until it hits the threshold). | |||
docs/src/lca.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Leaky Competing Accumulator | |||
|
|
|||
| The Leaky Competing Accumulator (LCA; Usher & McClelland, 2001) is a sequential sampling model in which evidence for options races independently. The LBA makes an additional simplification that evidence accumulates in a linear and ballistic fashion, meaning there is no intra-trial noise. Instead, evidence accumulates deterministically and linearly until it hits the threshold. | |||
| The Leaky Competing Accumulator (LCA; Usher & McClelland, 2001) is a sequential sampling model in which evidence for options races independently. the LCA is similar to the Linear Ballistic Accumulator (LBA), but additionally assumes an intra-trial noise in the form of evidence accumulation leakage (in contrast, the The LBA assumes that evidence accumulates in a ballistic fashion, i.e., linearly and deterministically until it hits the threshold). | |||
There was a problem hiding this comment.
Noise and leakage are separate concepts. I would say something like:
"intra-trial noise and leakage (in contrast, the The LBA assumes that evidence accumulates in a ballistic fashion, i.e., linearly and deterministically until it hits the threshold)
|
Thanks for the fixes to the docs. There were a few minor issues in the changes. I'll have to think about it some more, but I don't think making the drift rate a vector is a good idea. Using a scalar communicates to the user that there is only one drift rate, and prevents accidental use of multiple drift rates. |
Fair (though one could also throw an informative error "only one accumulator is possible for this model") |
|
Other minor consistency thing: LBA has the following order: drift, A, k, τ Does it make sense to standardize when possible? |
|
Yes. Standardizing the order is on my agenda. It became apparent I should do that when you opened the issue about the LBA doc strings the other day. Thanks for the suggestion. |
I still don't think that would be good to support officially, but to simplify your particular use case, you can define Thanks again for the fixes to the docs. |
Also removed reference to "of each accumulator" as exgauss doesn't have multiple accumualtors