Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Dockerfile #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Add Dockerfile #89

wants to merge 1 commit into from

Conversation

recrsn
Copy link

@recrsn recrsn commented Oct 18, 2017

Closes #84

  • Based on node:6 standard docker image

Copy link
Owner

@jacogreyling jacogreyling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amitosh! I see you're using both forms of ENV in your Dockerfile. Please pick one and stick with it for consistency. As you know with the latter form (with the = sign) you can have multiple env's in one definition and it's actually preferred, as per this statement, "...the first form [ref to = annotation] is preferred because it produces a single cache layer.". Then I also suggest you add the LABEL instruction with a 'description' which you can take from the package.json. Then probably the biggest one, we need Node 8 not 6 :) I take it you're going to create containers for mongodb and redis as well? Thanks again for your contribution! It's much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants