Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Protected Users check #112

Closed

Conversation

SamErde
Copy link
Collaborator

@SamErde SamErde commented Feb 16, 2024

Uploaded a renamed, working Protected Users check.

The rename aligns the PS1 filename with the function name.
I fixed a gap in the SID matching and also added a check for primaryGroupID (525).

The function is maintained at https://github.com/samerde/active-directory.

@SamErde SamErde added the bug Something isn't working label Feb 16, 2024
@SamErde SamErde requested a review from jakehildreth February 16, 2024 11:43
@SamErde SamErde self-assigned this Feb 16, 2024
Copy link
Owner

@jakehildreth jakehildreth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@SamErde SamErde closed this Feb 26, 2024
@SamErde SamErde deleted the SamErde-fix-ProtectedUsersCheck-01 branch February 26, 2024 21:17
@SamErde SamErde restored the SamErde-fix-ProtectedUsersCheck-01 branch February 26, 2024 21:17
@SamErde SamErde deleted the SamErde-fix-ProtectedUsersCheck-01 branch February 26, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants