Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter deny aces take 2 #120

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Filter deny aces take 2 #120

merged 2 commits into from
Feb 27, 2024

Conversation

jakehildreth
Copy link
Owner

How's this one look, @SamErde?

@jakehildreth jakehildreth requested a review from SamErde February 27, 2024 20:25
Copy link

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 16 1.84s
⚠️ EDITORCONFIG editorconfig-checker 26 1 0.2s
⚠️ MARKDOWN markdownlint 1 11 0.66s
⚠️ MARKDOWN markdown-link-check 1 9 2.23s
✅ MARKDOWN markdown-table-formatter 1 0 0.34s
⚠️ POWERSHELL powershell 25 17 33.76s
✅ POWERSHELL powershell_formatter 25 0 22.9s
⚠️ REPOSITORY checkov yes 1 11.09s
✅ REPOSITORY gitleaks yes no 0.44s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.17s
✅ REPOSITORY secretlint yes no 0.83s
✅ REPOSITORY trivy yes no 4.37s
✅ REPOSITORY trivy-sbom yes no 1.24s
✅ REPOSITORY trufflehog yes no 7.28s
⚠️ SPELL cspell 27 266 7.0s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@SamErde
Copy link
Collaborator

SamErde commented Feb 27, 2024

I like your commit-ment. 🥁

@SamErde
Copy link
Collaborator

SamErde commented Feb 27, 2024

I like that you kept the negative check for safeusers (allow-list approach) vs a positive check for unsafe users.

@SamErde SamErde merged commit aa372ef into testing Feb 27, 2024
3 checks passed
@jakehildreth jakehildreth deleted the filter-deny-aces-take-2 branch March 2, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants