ESC13 Detections and Issue Description Improvements. #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamErde
reviewed
Nov 11, 2024
| @@ -37,30 +43,42 @@ | |||
| !($_.'msPKI-Enrollment-Flag' -band 2) -and | |||
| ( ($_.'msPKI-RA-Signature' -eq 0) -or ($null -eq $_.'msPKI-RA-Signature') ) | |||
| } | ForEach-Object { | |||
| # Write-Host $_; continue | |||
There was a problem hiding this comment.
Was this a potential use case for Write-Debug?
SamErde
reviewed
Nov 11, 2024
|
|
||
| # If these are all empty = no issues found, exit | ||
| if ((!$AuditingIssues) -and (!$ESC1) -and (!$ESC2) -and (!$ESC3) -and (!$ESC4) -and (!$ESC5) -and (!$ESC6) -and (!$ESC8) -and (!$ESC11) ) { | ||
| if ((!$AuditingIssues) -and (!$ESC1) -and (!$ESC2) -and (!$ESC3) -and (!$ESC4) -and (!$ESC5) -and (!$ESC6) -and (!$ESC8) -and ($ESC11) -and ($ESC13) ) { |
There was a problem hiding this comment.
Missing the -not / ! operator for $ESC11 and $ESC13.
| @@ -4,7 +4,7 @@ | |||
| Finds the most common malconfigurations of Active Directory Certificate Services (AD CS). | |||
|
|
|||
| .DESCRIPTION | |||
| Locksmith uses the Active Directory (AD) Powershell (PS) module to identify 7 misconfigurations | |||
| Locksmith uses the Active Directory (AD) Powershell (PS) module to identify 10 misconfigurations | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ESC13 detections to Locksmith.
While I was in there, I decided to expand the descriptions of each issue so it's easier to tell why a misconfiguration is a problem.
Also added comments to the "Fix" and "Revert" code blocks for most issues so it's clear what actions are being performed.