Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESC15 Detections #187

Merged
merged 10 commits into from
Nov 25, 2024
Merged

Add ESC15 Detections #187

merged 10 commits into from
Nov 25, 2024

Conversation

jakehildreth
Copy link
Owner

Added ESC15 detections to all the places.

Also added links to Specterops, Compass, and TrustedSec write-ups of all the stuff Locksmith looks for.

Copy link

github-actions bot commented Nov 23, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 21 2.15s
⚠️ EDITORCONFIG editorconfig-checker 19 1 0.31s
⚠️ POWERSHELL powershell 19 16 33.14s
✅ POWERSHELL powershell_formatter 19 0 20.43s
⚠️ REPOSITORY checkov yes 1 13.87s
✅ REPOSITORY gitleaks yes no 0.5s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 18.07s
✅ REPOSITORY secretlint yes no 0.98s
✅ REPOSITORY trivy yes no 6.27s
✅ REPOSITORY trivy-sbom yes no 6.27s
✅ REPOSITORY trufflehog yes no 6.55s
⚠️ SPELL cspell 20 352 10.65s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@techspence
Copy link
Collaborator

The code runs successfully. When I ran this in my lab it returned the following hits:

  • User
  • UserSignature
  • ClientAuth
  • EFS
  • Machine
  • DomainController
  • IPSECIntermediateOnline
  • IPSECIntermediateOffline

None of these templates are intentionally misconfigured with any of the other ESC. Furthermore, when I requested a certificate for say the User template, I do not see "Application Policies" anywhere in the cert.

Are these false positives then?

Copy link
Collaborator

@techspence techspence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍I forgot to click the review button -.-

@jakehildreth
Copy link
Owner Author

Are these false positives then?

Nah, any Schema V1 template can be used to create a certificate with Application Policies attached. Depending on the exact Schema V1 template abused, you could end up with a wide variety of possible issue. Thankfully it's been patched!

For those reading: best practices are to create a duplicate of an existing Schema V1 template when creating a new template. This changes the Schema version to 2 and adds more functionality!

@jakehildreth jakehildreth merged commit 8536e80 into testing Nov 25, 2024
3 checks passed
@jakehildreth jakehildreth deleted the add-esc15-detections branch November 30, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants