Skip to content

Commit

Permalink
Merge pull request #7 from jakirkham/minor_fixes
Browse files Browse the repository at this point in the history
Minor fixes
  • Loading branch information
jakirkham committed Sep 24, 2015
2 parents 47decf1 + 6096771 commit 80eb78c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
3 changes: 3 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ ENV PATH=/opt/conda/bin:$PATH \
CONDA_DEFAULT_ENV=root \
CONDA_ENV_PATH=/opt/conda

RUN conda install -y drmaa && \
conda clean -tipsy

ADD docker /usr/share/docker
RUN /usr/share/docker/install_tini.sh

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ This repo is part of an automated build, which is hosted on Docker Hub ( <https:

## Manual

If one wishes to develop this repo, building will need to be performed manually. This container can be built simply by `cd`ing into the repo and using `docker build -t <NAME> .` where `<NAME>` is the name tagged to the image built. More information about building can be found in Docker's documentation ( <https://docs.docker.com/reference/builder> ). Please consider opening a pull request for changes that you make.
If one wishes to develop this repo, building will need to be performed manually. This container can be built simply by `cd`ing into the repo and using `docker build --rm -t <NAME> .` where `<NAME>` is the name tagged to the image built. More information about building can be found in Docker's documentation ( <https://docs.docker.com/reference/builder> ). Please consider opening a pull request for changes that you make.

# Testing

A simple test has been added during the installation of Grid Engine as this is the trickiest step and the one most likely to go wrong. The test submits a simple job and verifies that it runs successfully. As this occurs during the build process, failure of this test will terminate the build. Currently, Docker Hub does not provide a way to test the entrypoint to make sure it behaves properly. Ideally commonalities between the entrypoint and Grid Engine installation can be found and refactored out into a common script that both can use allowing it to be better tested. No direct testing of `conda` is performed. However, some basic installation and upgrading occurs, which should hopefully verify that it is working. Also, as this is pretty well tested by the team at Continuum, it is believed not to be at as serious of a risk.

# Usage

Once an image is acquired either from one of the provided builds or manually, the image is designed to provide a preconfigured shell environment. Simply run `docker run -it <NAME>`. This will configure Grid Engine and a number of environment variables useful for maintaining it and starts up `bash`. In the case of an automated build, `<NAME>` is `jakirkham/centos_drmaa_conda`.
Once an image is acquired either from one of the provided builds or manually, the image is designed to provide a preconfigured shell environment. Simply run `docker run --rm -it <NAME>`. This will configure Grid Engine and a number of environment variables useful for maintaining it and starts up `bash`. In the case of an automated build, `<NAME>` is `jakirkham/centos_drmaa_conda`.
3 changes: 0 additions & 3 deletions miniconda/install_miniconda.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,5 @@ conda install -y conda-build
conda install -y anaconda-client
conda install -y jinja2

# Install drmaa to provide Python support for DRMAA.
conda install -y drmaa

# Clean out all unneeded intermediates.
conda clean -yitps

0 comments on commit 80eb78c

Please sign in to comment.