V1.5.24 - The Solo Admin Special (#366)

* Further optimizations for full recalc rollup code paths by removing an intermediate inner class * Fixes issue reported by @solo-1234 where re-submitting a full recalc job for CMDT would improperly format the Rollup Order By CMDT records * Fixes issue reported by @solo-1234 where audit fields were causing RollupCalcItemReplacer to error out
jamessimone · Sep 30, 2022 · e8e6ac7 · e8e6ac7
1 parent 31888ff
commit e8e6ac7
Show file tree

Hide file tree

Showing 11 changed files with 250 additions and 197 deletions.
diff --git a/README.md b/README.md
@@ -14,12 +14,12 @@ As well, don't miss [the Wiki](../../wiki), which includes more advanced informa
 
 ## Deployment & Setup
 
-<a href="https://login.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008b0YSAAY">
+<a href="https://login.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008b0Z6AAI">
   <img alt="Deploy to Salesforce"
        src="./media/deploy-package-to-prod.png">
 </a>
 
-<a href="https://test.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008b0YSAAY">
+<a href="https://test.salesforce.com/packaging/installPackage.apexp?p0=04t6g000008b0Z6AAI">
   <img alt="Deploy to Salesforce Sandbox"
        src="./media/deploy-package-to-sandbox.png">
 </a>

diff --git a/extra-tests/classes/RollupCalcItemReplacerTests.cls b/extra-tests/classes/RollupCalcItemReplacerTests.cls
@@ -129,4 +129,19 @@ private class RollupCalcItemReplacerTests {
 
     System.assertEquals(ACC_ANNUAL_REVENUE, acc.AnnualRevenue);
   }
+
+  @IsTest
+  static void skipsNonUpdateableFields() {
+    Account acc = [SELECT Id, CreatedDate FROM Account];
+
+    RollupCalcItemReplacer replacer = new RollupCalcItemReplacer(
+      new RollupControl__mdt(IsRollupLoggingEnabled__c = true, ReplaceCalcItemsAsyncWhenOverCount__c = 1)
+    );
+    Account updatedAccount = (Account) replacer.replace(
+      new List<Account>{ new Account(Id = acc.Id) },
+      new List<Rollup__mdt>{ new Rollup__mdt(CalcItemWhereClause__c = 'CreatedDate != null') }
+    )[0];
+
+    System.assertEquals(acc.CreatedDate, updatedAccount.CreatedDate);
+  }
 }
diff --git a/extra-tests/customMetadata/Rollup.RollupIntegrationChildRollupText.md-meta.xml b/extra-tests/customMetadata/Rollup.RollupIntegrationChildRollupText.md-meta.xml
@@ -1,34 +1,38 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<CustomMetadata xmlns="http://soap.sforce.com/2006/04/metadata" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+<?xml version="1.0" encoding="UTF-8" ?>
+<CustomMetadata
+  xmlns="http://soap.sforce.com/2006/04/metadata"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xmlns:xsd="http://www.w3.org/2001/XMLSchema"
+>
     <label>RollupIntegrationChildRollupText</label>
     <protected>false</protected>
     <values>
         <field>CalcItemWhereClause__c</field>
-        <value xsi:nil="true"/>
+        <value xsi:nil="true" />
     </values>
     <values>
         <field>CalcItem__c</field>
         <value xsi:type="xsd:string">RollupChild__c</value>
     </values>
     <values>
         <field>ChangedFieldsOnCalcItem__c</field>
-        <value xsi:nil="true"/>
+        <value xsi:nil="true" />
     </values>
     <values>
         <field>ConcatDelimiter__c</field>
-        <value xsi:nil="true"/>
+        <value xsi:nil="true" />
     </values>
     <values>
         <field>FullRecalculationDefaultNumberValue__c</field>
-        <value xsi:nil="true"/>
+        <value xsi:nil="true" />
     </values>
     <values>
         <field>FullRecalculationDefaultStringValue__c</field>
-        <value xsi:nil="true"/>
+        <value xsi:nil="true" />
     </values>
     <values>
         <field>GrandparentRelationshipFieldPath__c</field>
-        <value xsi:nil="true"/>
+        <value xsi:nil="true" />
     </values>
     <values>
         <field>IsFullRecordSet__c</field>
@@ -50,10 +54,6 @@
         <field>LookupObject__c</field>
         <value xsi:type="xsd:string">RollupParent__c</value>
     </values>
-    <values>
-        <field>OrderByFirstLast__c</field>
-        <value xsi:type="xsd:string">TextField__c</value>
-    </values>
     <values>
         <field>RollupControl__c</field>
         <value xsi:type="xsd:string">Org_Defaults</value>
@@ -76,6 +76,6 @@
     </values>
     <values>
         <field>UltimateParentLookup__c</field>
-        <value xsi:nil="true"/>
+        <value xsi:nil="true" />
     </values>
 </CustomMetadata>
diff --git a/extra-tests/customMetadata/RollupOrderBy.Integration_TextValue_FIRST.md-meta.xml b/extra-tests/customMetadata/RollupOrderBy.Integration_TextValue_FIRST.md-meta.xml
@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<CustomMetadata
+  xmlns="http://soap.sforce.com/2006/04/metadata"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xmlns:xsd="http://www.w3.org/2001/XMLSchema"
+>
+    <label>Integration TextValue FIRST</label>
+    <protected>false</protected>
+    <values>
+        <field>FieldName__c</field>
+        <value xsi:type="xsd:string">TextField__c</value>
+    </values>
+    <values>
+        <field>NullSortOrder__c</field>
+        <value xsi:type="xsd:string">NULLS FIRST</value>
+    </values>
+    <values>
+        <field>Ranking__c</field>
+        <value xsi:type="xsd:double">0.0</value>
+    </values>
+    <values>
+        <field>Rollup__c</field>
+        <value xsi:type="xsd:string">RollupIntegrationChildRollupText</value>
+    </values>
+    <values>
+        <field>SortOrder__c</field>
+        <value xsi:type="xsd:string">Ascending</value>
+    </values>
+</CustomMetadata>
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "apex-rollup",
-  "version": "1.5.23",
+  "version": "1.5.24",
   "description": "Fast, configurable, elastically scaling custom rollup solution. Apex Invocable action, one-liner Apex trigger/CMDT-driven logic, and scheduled Apex-ready.",
   "repository": {
     "type": "git",