Skip to content

Commit

Permalink
Force a virtual libcurl provides/depends pinned to package-version
Browse files Browse the repository at this point in the history
Signed-off-by: Jamon <jamon@chainguard.dev>
  • Loading branch information
jamonation committed Feb 6, 2025
1 parent 39a708f commit 03224f8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
4 changes: 3 additions & 1 deletion curl-rustls.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package:
name: curl-rustls
version: "8.12.0"
epoch: 0
epoch: 1
description: "URL retrieval utility and library"
copyright:
- license: MIT
Expand Down Expand Up @@ -67,6 +67,8 @@ subpackages:
description: "curl library (rustls backend)"
dependencies:
provider-priority: 10
provides:
- libcurl=${{package.full-version}}

This comment has been minimized.

Copy link
@xnox

xnox Feb 6, 2025

@jamonation

this breaks when curl.yaml & curl-rustls.yaml epoch get out of sync; when one is rebuild (for any reason) without rebuilding the other.

For example as part of abi transitions; as curl & curl-rustls have widely different runtime abi dependencies.

This is same comment that was left on wolfi-dev#41405

This comment has been minimized.

Copy link
@jamonation

jamonation Feb 6, 2025

Author Owner

Ah hang on, I missed forcing the depends on libcurl=${{package.full-version}}

pipeline:
- runs: |
mkdir -p "${{targets.subpkgdir}}"/usr/lib
Expand Down
7 changes: 6 additions & 1 deletion curl.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
package:
name: curl
version: "8.12.0"
epoch: 0
epoch: 1
description: "URL retrieval utility and library"
copyright:
- license: MIT
dependencies:
runtime:
- libcurl

environment:
contents:
Expand Down Expand Up @@ -87,6 +90,8 @@ subpackages:
# raise the priority here so this beats rustls
# TODO: revert this to "5" once rustls is fixed.
provider-priority: 15
provides:
- libcurl=${{package.full-version}}
pipeline:
- runs: |
mkdir -p "${{targets.subpkgdir}}"/usr/lib
Expand Down

0 comments on commit 03224f8

Please sign in to comment.