-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EScAIP Model #191
base: main
Are you sure you want to change the base?
Add EScAIP Model #191
Conversation
- include model names in get_pred_file_urls output
thanks a lot @EricZQu for submitting EScAIP! could you also share
|
models/escaip/escaip.yml
Outdated
requirements: | ||
fairchem-core: 1.2.1 | ||
|
||
openness: OSCD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labelling the model OSCD [Open source, closed data] is incompatible with it just being trained on MPtrj below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, this was a copy paste error on my part (i remember copying this from MACE-MPA-0). will add a test to catch this in future. probably each dataset in training-sets.yml
should have an openness key as well
Hey maintainers,
Thanks for all the awesome work on this benchmark! I’m submitting our new model with this PR. Let me know if anything else is needed.