Download files to right locations to allow plotting. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing it to be removed from pymatviz given deprecated terminology (see #131)
…e the plots themselves again. blocked as the file urls are private
- add maybe_auto_download_file() used in Model.(discovery|geo_opt|kappa_103)_path - introduce env var MBD_AUTO_DOWNLOAD_FILES and MBD_CACHE_DIR for download control - Files enum add abstractmethods for url and label properties so child classes must implement - test coverage for new download functionality - remove scripts/download_model_preds_from_figshare.py
janosh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files were removed from version control but now need a way to download easily to allow plotting scripts and analysis to be used.
Also some clean-up of code decay wrt enums and slight change to dpa LAM model to avoid Alex sAlex duplication in reported training data.