make sure a virtual column being opened focusses on the name

jasp-stats · Nov 6, 2024 · 42d471e · 42d471e
1 parent 8691b8b
commit 42d471e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 15 deletions.
diff --git a/Desktop/components/JASP/Widgets/ColumnBasicInfo.qml b/Desktop/components/JASP/Widgets/ColumnBasicInfo.qml
@@ -34,21 +34,21 @@ Item
 	property alias columnComputedTypeValue:	computedTypeVariableWindow.value
 	property alias columnTypeValue:			columnTypeVariableWindow.value
 
+	function focusOnTheNamePlease()
+	{
+		if (visible && columnModel.isVirtual)
+			columnNameVariablesWindow.forceActiveFocus()
+	}
+
 	Connections
 	{
 		target: columnModel
-		function onVisibleChanged()
-		{
-			if (visible && columnModel.isVirtual)
-				columnNameVariablesWindow.forceActiveFocus()
-		}
-
-		function onChosenColumnChanged()
-		{
-			if (visible && columnModel.isVirtual)
-				columnNameVariablesWindow.forceActiveFocus()
-		}
+		function onVisibleChanged()			{ focusOnTheNamePlease(); }
+		function onChosenColumnChanged()	{ focusOnTheNamePlease(); }
+		function onIsVirtualChanged()		{ focusOnTheNamePlease(); }
 	}
+
+
 
 	Column
 	{

diff --git a/Desktop/components/JASP/Widgets/ComputeColumnWindow.qml b/Desktop/components/JASP/Widgets/ComputeColumnWindow.qml
@@ -45,18 +45,18 @@ FocusScope
 			computedColumnsInterface.sendCode(computeColumnEdit.text)
 		else
 		{
+			computedColumnConstructor.forceActiveFocus();
 			computedColumnConstructor.checkAndApplyFilter()
 			computedColumnsInterface.sendCode(computedColumnConstructor.rCode, computedColumnConstructor.jsonConstructed)
 		}
 	}
 
 	function askIfChangedOrClose()
 	{
-		if(computedColumnContainer.changed)	saveDialog.open()
+		if(computedColumnContainer.changed)	
+			saveDialog.open()
 	}
 
-
-
 	Item
 	{
 		id:				minWidthCollector

diff --git a/Desktop/components/JASP/Widgets/FilterConstructor/ComputedColumnsConstructor.qml b/Desktop/components/JASP/Widgets/FilterConstructor/ComputedColumnsConstructor.qml
@@ -34,7 +34,6 @@ FocusScope
 
 	function checkAndApplyFilter()
 	{
-		forceActiveFocus();
 		filterConstructor.somethingChanged = false
 
 		var allCorrect		= true