ok so the refresh serves a purpose

jasp-stats · Nov 27, 2024 · 4c7faf7 · 4c7faf7
1 parent 268b031
commit 4c7faf7
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/Desktop/data/datasetpackage.cpp b/Desktop/data/datasetpackage.cpp
@@ -1634,13 +1634,12 @@ void DataSetPackage::setColumnName(size_t columnIndex, const std::string & newNa
 
 	std::string oldName = getColumnName(columnIndex);
 
-	if(!column->setName(newName))
-		return;
-
-
-	setManualEdits(true);
-	emit datasetChanged({}, {}, QMap<QString, QString>({{tq(oldName), tq(newName)}}), false, false);
-	refresh();
+	if(column->setName(newName))
+	{
+		setManualEdits(true);
+		emit datasetChanged({}, {}, QMap<QString, QString>({{tq(oldName), tq(newName)}}), false, false);
+	}
+	refresh(); //We do refresh in any case because then the emptied name of the column in variableswindow will get filled again
 }
 
 void DataSetPackage::setColumnTitle(size_t columnIndex, const std::string & newTitle)