Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JASP on the small screen #5322

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

JorisGoosen
Copy link
Contributor

  • FileMenu should be scrollable
  • OSF Login now has a minified version for tiny windows
  • MainWindow now can be minimum 400 * scaling insteead of 640 * scaling
  • VariablesWindow column info now moves into a tab if it gets too small (Allows computed columns drag&drop to actually be usable)

OSF Login:
Big:
afbeelding

Small:
afbeelding

Variables:
Small:
afbeelding

Small computed column Drag&drop:
afbeelding

big:
afbeelding

JorisGoosen and others added 2 commits November 15, 2023 12:39
OSFLogin should handle being very small better
…o small

should solve jasp-stats/jasp-issues#2406 (computed column hard to see small window)
@JorisGoosen JorisGoosen requested a review from boutinb November 15, 2023 13:03
@JorisGoosen
Copy link
Contributor Author

Ah I should also make the module menu scrollable

This makes it smaller than it was before which makes the preference menus *just* usable on the minimumwindow size
I did move the treshold spinbox down a bit to make it fit
@JorisGoosen
Copy link
Contributor Author

afbeelding

And as you can see with a different language the sizes are now different too:
afbeelding

Preferences is now mostly usable on tiny screens (although for japanese it might get a bit cramped due to the font+characterset)
afbeelding

@JorisGoosen JorisGoosen marked this pull request as ready for review November 15, 2023 14:43
@boutinb boutinb merged commit 9fbd814 into jasp-stats:development Nov 15, 2023
JorisGoosen added a commit that referenced this pull request Jan 2, 2024
* FileMenu scrollable, better z and background
OSFLogin should handle being very small better

* VariablesWindow should just show column info in a tab when it gets too small

should solve jasp-stats/jasp-issues#2406 (computed column hard to see small window)

* Modules menu should also scroll in edit mode

* FileMenu now dynamically determines the required size for the buttons
This makes it smaller than it was before which makes the preference menus *just* usable on the minimumwindow size
I did move the treshold spinbox down a bit to make it fit

* also show column info for virtual column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants