Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Variables List with layers for contingency table analysis #5734

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

boutinb
Copy link
Contributor

@boutinb boutinb commented Nov 13, 2024

Fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/2683

I'm not sure if a Layer Variables List with several layers has ever worked properly. It was at least not possible to load a JASP file with a contingency table analysis with several layers. To reproduce the problem, you can also just duplicate the analysis.

Fixes jasp-stats/INTERNAL-jasp#2683

I'm not sure if a Layer Variables List with several layers has ever worked properly. It was at least not possible to load a JASP file with a contingency table analysis with several layers.
To reproduce the problem, you can also just duplicate the analysis.
@boutinb boutinb requested a review from JorisGoosen November 13, 2024 16:31
Copy link
Contributor

@JorisGoosen JorisGoosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work fine and if you are ok with my replacing the std::tie by the auto [] thing it can be merged.

Consistency is always appreciated ;)

QMLComponents/models/listmodellayersassigned.cpp Outdated Show resolved Hide resolved
QMLComponents/models/listmodellayersassigned.cpp Outdated Show resolved Hide resolved
@JorisGoosen JorisGoosen merged commit 2408af9 into jasp-stats:development Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants