Variable type change in CFA does not rerun the analysis #5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FactorForms does not specify the types of its variables in the options. So this information is lost. But this information is needed in the CFA analysis, since it is possible in this analysis to change the variable type. Also if you change the type, the analysis is not rerun.
boutinb
changed the title
JorisGoosen
approved these changes
Jan 9, 2025
juliuspfadt
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Factors Form widget does not store the types of its variables in the options. So this information is lost. But this information is needed in the CFA analysis, since it is possible in this analysis to change the variable type. Also if you change the type, the analysis is not rerun.
This fix takes care of backward compatibility: a JASP file from 0.19.3 or older containg a CFA analysis (or a Regression Linear or Logistic Regression analysis that uses also a Factors Form widget) can be read.
The jaspTestModule has been updated to test also type change in Factors Form.