Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: payouts table in distribute payouts modal #4212

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

johnnyd-eth
Copy link
Contributor

Some minor fixes to the payouts table in "distribute payouts" modal when only owner split the owner split is present.

Before:

Screen Shot 2024-01-18 at 3 02 53 pm

Implemented:

  • When there are no payouts and an owner split (like above):

  • remove sub-total row

  • change “Remaining…” to the owner wallet address

  • make owner row amount account for fee

  • Check all other instances of the payouts table to check they are behaving as usual.

After:

Screen Shot 2024-01-18 at 2 47 02 pm

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
juice-interface ⬜️ Ignored (Inspect) Jan 18, 2024 7:05am
juice-interface-goerli ⬜️ Ignored (Inspect) Jan 18, 2024 7:05am

@johnnyd-eth johnnyd-eth requested a review from tomquirk January 18, 2024 07:05
@tomquirk tomquirk merged commit 226788a into main Jan 20, 2024
4 checks passed
@tomquirk tomquirk deleted the payouts-table-no-payouts branch January 20, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants