Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toString bug #4237

Merged
merged 2 commits into from
Jan 28, 2024
Merged

fix: toString bug #4237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ad3448
fix: toString bug
tomquirk Jan 28, 2024
966dfbc
comment
tomquirk Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ts/v2v3/V2V3Project/ProjectDashboard/components/Cart/hooks/useRewardEligibilityCallout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const useRewardEligibilityCallout = () => {

const weiPayAmount = useWeiConverter({
currency: payAmount?.currency,
amount: payAmount?.amount.toString(),
amount: payAmount?.amount?.toString(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if this is even an issue. just came across it, and thought it might be given the typing issue below

})

const eligibleRewards = useMemo(() => {
Expand Down
4 changes: 2 additions & 2 deletions ...s/v2v3/V2V3Project/ProjectDashboard/components/PayProjectCard/components/TokensPerEth.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ export const TokensPerEth = ({
}: {
currencyAmount:
| {
amount: number
amount: number // NOTE this is actually a `string | undefined` from what I can tell. Too scared to change it atm.
currency: V2V3CurrencyOption
}
| undefined
}) => {
const { currencyText, receivedTickets, receivedTokenSymbolText } =
useTokensPerEth({
amount: parseFloat(currencyAmount?.amount.toString() || '1'),
amount: parseFloat(currencyAmount?.amount?.toString() || '1'),
currency: currencyAmount?.currency || V2V3_CURRENCY_ETH,
})

Expand Down
Loading