Demonstrate adding findsecbugs to spotbugs. #432
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrate adding findsecbugs to spotbugs. This commit is a demonstration and is not intended to be merged as-is.
Findsecbugs reports several findings for this plugin, but all of them can be safely suppressed. There are a few that could be a concern, but examination shows that as currently used they do not introduce a vulnerability. While the MD5 usage here is used for tracking and not security, this serves a reminder that it would be better to migrate to a better algorithm. See JENKINS-60563.
This also uses the exclude file for a couple of finding types that are fairly common in Jenkins but not considered a concern.
My plan is to add findsecbugs at the plugin pom after sufficient testing and communication. At that point, it would make sense to add the suppressions, but not the pom file changes from this PR.