Update to /v2 api endpoint #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s instead of directly with the chapter.
|
this is amazing @ralamiri , thank you so much for the fix 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should resolve the issue regarding the covers/images that is present on the main branch of this project. I updated the functionality of it to support the /v2 api endpoints that is used by default in O'Reilly, and resolved the depreciation warning from node.
Do note that there's still no proper error handling for the 500 error on images, so if those do come up at a later time, that would still need to be resolved, meaning that Issue #21 should still be open following this merge.