Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test for a config with a negative refspec #4382

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

radsaq
Copy link
Contributor

@radsaq radsaq commented Mar 9, 2025

  • PR Description

This is a sanity check to verify that lazygit has been built with a patched version of go-git that does not error on negative refspecs.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@radsaq radsaq force-pushed the test-negative-refspec branch from 46f5299 to 901d4e4 Compare March 11, 2025 01:04
@radsaq
Copy link
Contributor Author

radsaq commented Mar 11, 2025

I added a git version condition.

@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label Mar 11, 2025
@stefanhaller
Copy link
Collaborator

Nice, looks good. I verified that the test fails when f03e1e4 is reverted. Merging.

@stefanhaller stefanhaller enabled auto-merge March 11, 2025 07:33
@stefanhaller stefanhaller force-pushed the test-negative-refspec branch from 901d4e4 to b76b739 Compare March 11, 2025 07:33
@stefanhaller stefanhaller merged commit d423d2a into jesseduffield:master Mar 11, 2025
15 checks passed
@radsaq radsaq deleted the test-negative-refspec branch March 12, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance For refactorings, CI changes, tests, version bumping, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants