feat(runtime): use compileFunction over new Script
#15461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimenB
commented
Jan 16, 2025
| '__tests__/b.test.js': "test('b', () => console.log('b'));", | ||
| 'package.json': JSON.stringify({jest: {testEnvironment: 'jsdom'}}), | ||
| }); | ||
| onNodeVersions('> 16', () => { |
There was a problem hiding this comment.
this is unfortunate, but hopefully most people have moved on from node 16 😀
G-Rath
reviewed
Jan 17, 2025
Co-authored-by: Gareth Jones <Jones258@Gmail.com>
|
The following CI checks should also be removed in this case: |
|
Also: there's a line in the changelog about dropped node versions. v16 should be added to the list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reapplies and closes #12205.
Node 16 still has issues (and I don't intend to drop it for Jest 30), but most people are deffo on newer versions than that
Test plan
CI?