Make @jest/reporters a peerDependency, and bump the required version down #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions of Jest in repos with older versions
|
Thanks @sophiekoonin, looks great! I'll test it this evening and release a new version once I've verified it doesn't cause any havoc in my own project. |
SimenB
reviewed
Jan 18, 2021
| "chalk": "^4.1.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@jest/reporters": "^25.0.0" |
There was a problem hiding this comment.
Suggested change
| "@jest/reporters": "^25.0.0" | |
| "@jest/reporters": "^25.1.0 || ^26.0.0" |
25.1.0 was first stable version of 25 (a version that was supposed to be a pre-release may or may not have been tagged as latest. npm is hard sometimes 👼).
Also, should still support v26
|
Released as 0.2.0. Note that in order to stop npm complaing, I took on a peer dependency to Thanks @sophiekoonin! 🤝 Thanks @SimenB for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, it won't install files from a newer major version of Jest in repos that are still on v25.
The tool runs perfectly well in v25, so figured it may as well require that rather than v26.