Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace scss-parser with gonzales-pe #19

Merged
merged 4 commits into from
Dec 2, 2017

Conversation

phlmn
Copy link
Contributor

@phlmn phlmn commented Oct 17, 2017

Hey,

I've replaced scss-parser with gonzales-pe to increase compatibility with certain SCSS features, most likely varargs. This fixes #18. Two tests are not running yet, maybe you've an idea for that.

I also added an editorconfig file.

Cheers,
Philipp

@jgranstrom
Copy link
Owner

@phlmn thank you, I also noticed the varargs issues, sass has a pretty a huge set of features to cover. Unfortunately I have been knee deep in all kinds of things the last weeks so haven't had time to look into it. Will check this alternative parser out tonight and see if we can iron out the remaining issues for a new release.

@bencergazda
Copy link
Contributor

bencergazda commented Nov 13, 2017

I just had some time today to test the gonzales-pe-version, this also fixes my issue with scss-parser. Finally I could import my whole module tree for sass-extract.

Thank you @jgranstrom for putting the plugin together, and thanks for @phlmn for creating the gonzales-pe version of it. Hope it will be included to the plugin. :-)

@jgranstrom jgranstrom merged commit 64c7219 into jgranstrom:master Dec 2, 2017
@jgranstrom
Copy link
Owner

@phlmn @bencergazda this and more has been included in the latest 2.0.0 release. Thank you for your work with the parser!

@phlmn phlmn deleted the gonzales-pe branch December 2, 2017 19:31
@phlmn phlmn restored the gonzales-pe branch December 2, 2017 19:32
@phlmn
Copy link
Contributor Author

phlmn commented Dec 12, 2017

@jgranstrom Awesome! 😊 Still has problems with Bootstrap 4.0.0-beta.2 but that's probably a syntax error in their code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem parsing varargs
3 participants