Merge pull request #359 from jibedoubleve/issue/324

Issue/324

src/Lanceur/Ui/Dialogs.cs

@@ -7,7 +7,7 @@ public static class DialogMixin
     {
         #region Methods
 
-        public static bool AsBool(this ContentDialogResult result)
+        public static bool ToBool(this ContentDialogResult result)
         {
             return result switch
             {

src/Lanceur/Views/DoubloonsView.xaml.cs

@@ -27,7 +27,7 @@ public DoubloonsView()
                     long.TryParse(interaction.Input, out value);
 
                     var result = await Dialogs.YesNoQuestion($"Do you want to delete {interaction.Input} {(value > 1 ? "aliases" : "alias")}?");
-                    interaction.SetOutput(result.AsBool());
+                    interaction.SetOutput(result.ToBool());
                 });
 
                 ViewModel.Activate.Execute().Subscribe();

src/Lanceur/Views/InvalidAliasView.xaml.cs

@@ -27,7 +27,7 @@ public InvalidAliasView()
                     long.TryParse(interaction.Input, out value);
 
                     var result = await Dialogs.YesNoQuestion($"Do you want to delete {interaction.Input} {(value > 1 ? "aliases" : "alias")}?");
-                    interaction.SetOutput(result.AsBool());
+                    interaction.SetOutput(result.ToBool());
                 });
 
                 ViewModel.Activate.Execute().Subscribe();

src/Lanceur/Views/KeywordsView.xaml.cs

@@ -42,7 +42,7 @@ public KeywordsView()
                 ViewModel.ConfirmRemove.RegisterHandler(async interaction =>
                 {
                     var result = await Dialogs.YesNoQuestion($"Do you want to delete alias '{interaction.Input}' and all its synonyms?");
-                    interaction.SetOutput(result.AsBool());
+                    interaction.SetOutput(result.ToBool());
                 });
 
                 this.OneWayBind(ViewModel, vm => vm.Aliases, v => v.Aliases.ItemsSource).DisposeWith(d);

src/Lanceur/Views/PluginsView.xaml.cs

@@ -53,7 +53,7 @@ public PluginsView()
                 {
                     var result =
                         await Dialogs.YesNoQuestion($"Do you want to uninstall the plugin '{interaction.Input}'?");
-                    interaction.SetOutput(result.AsBool());
+                    interaction.SetOutput(result.ToBool());
                 });
             };
             ViewModel.Activate.Execute().Subscribe();

src/Lanceur/Views/SessionsView.xaml.cs

@@ -21,7 +21,7 @@ public SessionsView()
                 ViewModel.ConfirmRemove.RegisterHandler(async interaction =>
                 {
                     var result = await Dialogs.YesNoQuestion($"Do you want to remove alias '{interaction.Input}'?");
-                    interaction.SetOutput(result.AsBool());
+                    interaction.SetOutput(result.ToBool());
                 });
 
                 this.OneWayBind(ViewModel, vm => vm.Sessions, v => v.CbSessions.ItemsSource).DisposeWith(d);

src/Libraries/System.IO.FileOps/Infrastructure/AbstractOperationScheduler.cs

@@ -21,7 +21,7 @@ internal abstract class AbstractOperationScheduler : IOperationScheduler
 
     private static IEnumerable<IOperation> GetOperations(IEnumerable<OperationConfiguration> configurations)
     {
-        return configurations.Select(cfg => cfg.AsOperation()).ToList();
+        return configurations.Select(cfg => cfg.ToOperation()).ToList();
     }
 
     protected IOperationScheduler AddOperations(IEnumerable<OperationConfiguration> operations, bool resetList = true)

src/Libraries/System.IO.FileOps/Infrastructure/OperationMixin.cs

@@ -17,16 +17,16 @@ public static class OperationMixin
 
     #region Methods
 
-    public static IOperation AsOperation(this OperationConfiguration cfg)
+    public static IOperation ToOperation(this OperationConfiguration cfg)
     {
         var type =
             (from t in Types
              where t.FullName == cfg.Name
              select t).FirstOrDefault();
 
-        if (type is null) throw new NotSupportedException($"Cannot find operation '{cfg.Name}'");
-
-        return (IOperation)Activator.CreateInstance(type, cfg.Parameters)!;
+        return type is null
+            ? throw new NotSupportedException($"Cannot find operation '{cfg.Name}'")
+            : (IOperation)Activator.CreateInstance(type, cfg.Parameters)!;
     }
 
     #endregion Methods

src/Tests/System.IO.FileOps.Tests/SystemTests/Operations/MoveDirectoryOperationShould.cs

@@ -55,7 +55,7 @@ public async Task BeProcessed()
     {
         // ACT
         var moveDirectory = OperationFactory.MoveDirectory(Source, Destination);
-        await moveDirectory.AsOperation()
+        await moveDirectory.ToOperation()
                            .ProcessAsync();
 
         // ASSERT

src/Tests/System.IO.FileOps.Tests/SystemTests/Operations/RemoveDirectoryOperationShould.cs

@@ -19,7 +19,7 @@ public async Task BeProcessed()
         var rmdir = OperationFactory.RemoveDirectory(directory);
         Directory.Exists(directory).Should().BeTrue();
 
-        await rmdir.AsOperation()
+        await rmdir.ToOperation()
                    .ProcessAsync();
 
         // ASSERT

src/Tests/System.IO.FileOps.Tests/SystemTests/Operations/UnzipDirectoryOperationShould.cs

@@ -64,7 +64,7 @@ public async Task BeProcessed()
     {
         // ACT
         var unzipDir = OperationFactory.UnzipDirectory(ArchiveFile, Destination);
-        await unzipDir.AsOperation()
+        await unzipDir.ToOperation()
                       .ProcessAsync();
 
         // ASSERT