refactor to use modern attr patterns #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also this will fix #52 |
|
When will this be merged? The error indicates 2022.10 will break the integration, so I haven't upgraded yet. |
|
I don’t really want to fork, but you can temporarily use my repo as it has the fix on main. You will need to remove and add my repo in HACS. The config should just work on boot. |
|
@dwradcliffe did you see this Error 400 report? #58. I haven't installed from your repo yet. I also haven't upgrade to 2022.10 yet :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current recommended way to set entity properties is with attributes named via convention: https://developers.home-assistant.io/docs/core/entity#entity-class-or-instance-attributes
This removes a lot of boilerplate code which keeps things simpler.