Skip to content

Commit 2c03569

Browse files
committed
feat: make custom domain conditional on main
1 parent 176ab8b commit 2c03569

File tree

2 files changed

+23
-15
lines changed

2 files changed

+23
-15
lines changed

.github/workflows/shared-build-and-deploy.yaml

+7-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Build and deploy
1+
name: Shared build and deploy
22

33
on:
44
workflow_call:
@@ -108,6 +108,9 @@ jobs:
108108
webServiceImage="${{ needs.build.outputs.image-name }}:sha-${{ needs.build.outputs.sha-short }}"
109109
echo "webServiceImage=$webServiceImage"
110110
111+
webServiceContainerAppName='${{ env.BRANCH_NAME }}-web'
112+
echo "webServiceContainerAppName=$webServiceContainerAppName"
113+
111114
TAGS='{"owner":"johnnyreilly", "email":"johnny_reilly@hotmail.com"}'
112115
az deployment group create \
113116
--resource-group ${{ env.RESOURCE_GROUP }} \
@@ -118,10 +121,11 @@ jobs:
118121
containerRegistry=${{ env.REGISTRY }} \
119122
containerRegistryUsername=${{ github.actor }} \
120123
containerRegistryPassword=${{ secrets.PACKAGES_TOKEN }} \
124+
branchName='${{ env.BRANCH_NAME }}' \
121125
workspaceName='shared-log-analytics' \
122126
appInsightsName='shared-app-insights' \
123127
managedEnvironmentName='shared-env' \
124-
webServiceContainerAppName='${{ env.BRANCH_NAME }}-web' \
128+
webServiceContainerAppName="$webServiceContainerAppName" \
125129
tags="$TAGS" \
126130
APPSETTINGS_API_KEY="${{ secrets.APPSETTINGS_API_KEY }}" \
127131
APPSETTINGS_DOMAIN="${{ vars.APPSETTINGS_DOMAIN }}" \
@@ -130,7 +134,7 @@ jobs:
130134
131135
CONTAINER_APP_URL=$(az containerapp show \
132136
--resource-group '${{ env.RESOURCE_GROUP }}' \
133-
--name '${{ env.BRANCH_NAME }}-web' \
137+
--name "$webServiceContainerAppName" \
134138
--query properties.configuration.ingress.fqdn \
135139
--output tsv)
136140

infra/main.bicep

+16-12
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ param containerRegistryUsername string
55
@secure()
66
param containerRegistryPassword string
77

8+
param branchName string
9+
810
param workspaceName string
911
param appInsightsName string
1012
param managedEnvironmentName string
@@ -96,19 +98,21 @@ resource webServiceContainerApp 'Microsoft.App/containerApps@2024-03-01' = {
9698
ingress: {
9799
external: true
98100
targetPort: 3000
99-
customDomains: [
100-
// {
101-
// name: 'poorclaresarundel.org'
102-
// certificateId: '/subscriptions/subscription-id/resourceGroups/rg-poor-clares-arundel-aca/providers/Microsoft.App/managedEnvironments/shared-env/certificates/poorclaresarundel.org'
103-
// bindingType: 'SniEnabled'
104-
// }
101+
customDomains: branchName == 'main'
102+
? [
103+
// {
104+
// name: 'poorclaresarundel.org'
105+
// certificateId: '/subscriptions/subscription-id/resourceGroups/rg-poor-clares-arundel-aca/providers/Microsoft.App/managedEnvironments/shared-env/certificates/poorclaresarundel.org'
106+
// bindingType: 'SniEnabled'
107+
// }
105108

106-
{
107-
name: 'www.poorclaresarundel.org'
108-
certificateId: '${managedEnvironment.id}/certificates/poorclaresarundel.org'
109-
bindingType: 'SniEnabled'
110-
}
111-
]
109+
{
110+
name: 'www.poorclaresarundel.org'
111+
certificateId: '${managedEnvironment.id}/certificates/poorclaresarundel.org'
112+
bindingType: 'SniEnabled'
113+
}
114+
]
115+
: []
112116
}
113117
}
114118
template: {

0 commit comments

Comments
 (0)