pkp#97 Updated code to use the table's primary key

jonasraoni · Jan 31, 2025 · 71d1e86 · 71d1e86
1 parent d533569
commit 71d1e86
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/classes/migration/upgrade/I57_UpdateSettings.php b/classes/migration/upgrade/I57_UpdateSettings.php
@@ -30,8 +30,8 @@ public function up(): void
         $settings = DB::table('plugin_settings')
             ->where('plugin_name', '=', 'plnplugin')
             ->whereIn('setting_name', ['terms_of_use', 'terms_of_use_agreement'])
-            ->pluck('setting_value', 'setting_name');
-        foreach ($settings as $name => $value) {
+            ->pluck('setting_value', 'plugin_setting_id');
+        foreach ($settings as $id => $value) {
             $isUpdateRequired = false;
             try {
                 $value = json_decode($value, true, 512, JSON_THROW_ON_ERROR);
@@ -58,8 +58,7 @@ public function up(): void
 
             if ($isUpdateRequired) {
                 DB::table('plugin_settings')
-                    ->where('plugin_name', '=', 'plnplugin')
-                    ->where('setting_name', '=', $name)
+                    ->where('plugin_setting_id', '=', $id)
                     ->update(['setting_value' => json_encode($value)]);
             }
         }