Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Convert from_type to parent logical type before attempting a cast. #1508

Closed
wants to merge 1 commit into from
Closed

Convert from_type to parent logical type before attempting a cast. #1508

wants to merge 1 commit into from

Conversation

GPSnoopy
Copy link
Contributor

This is part of larger PR for polars pola-rs/polars#9373.

Though it does seem to be the right thing when doing a cast and dealing with extension types.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2d2e705) 83.47% compared to head (2078857) 83.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1508   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files         388      388           
  Lines       41996    41997    +1     
=======================================
+ Hits        35057    35058    +1     
  Misses       6939     6939           
Impacted Files Coverage Δ
src/compute/cast/mod.rs 90.67% <100.00%> (+0.01%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GPSnoopy
Copy link
Contributor Author

Closing PR as per pola-rs/polars#9373 (comment)

@GPSnoopy GPSnoopy closed this Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant