Revision for Play v. 2.5.7 "Streamy" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 14, 2016 10:30
…ntrollers.common.Assets
|
@amrodrigues Thank you for submitting this PR, and I'm so sorry about the delayed response. I must have missed the GitHub notification for this. I don't really have a means for validating your (much appreciated) PR since I don't have any automated tests on this repo, though I do see there's a merge conflict right now. Can you offer an opinion on the stability of these changes? One option is I could tag the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Josh, I did a quick, full revision while making it more "barebones" for a wider audience. Also IntelliJ IDEA config might be tricky for some developers and it seems OK to add it to projects, so I did that.
I wasn't planning to work on this as a proof of concept or to push it back to GitHub, so I'm sorry but I used the master branch and butchered some bits of code like flywaydb, the Git hash example and Bootstrap. I wouldn't have done it otherwise :p
Thanks.