Docker healthcheck #136
Merged
Docker healthcheck #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Speeds up initial go build times by 6x (from 60s to 10s), faster than front-end
- Add new /api/health endpoint - Implement health status check (health.go) - Return appropriate HTTP status codes
- was inconsistent due to being too fast
- Added healthcheck for frontend, backend and proxy - Backend & frontend initial grace period is set to 60s due to long initial build/install times
- Monitors docker container health status - Checks frontend, backend, and proxy containers - Implements retry mechanism (60 attempts, 1s intervals) - Parses container status using regex
- port over health check to non-wsl - have kubernetes use the new /api/health endpoint - remove now unused /api/healthcheckz endpoint - remove unnecessary extra playwright profiles in testing.
joshzcold
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
Description:
Running tests now (on dev wsl):
global.setup.js, which checks if all containers are healthy, if they are not healthy in 60s, it fails and tests don't runnginxandfrontendhealth checks pass with just a response,backendnow has a dedicated/api/healthendpoint which checks eachbackendcomponent - if one of them is down, it returns503instead of200Changes made:
e4f5b24 modifies backend dev dockerfile to use caching speeds up build times by 6x
9ddd701 adds
/api/healthendpoint which checksWebsocketandStorereadinessdcbe06d adds timeouts to flaky game board hiding test
944a58e adds docker health check to
docker-compose-dev-wsl.yaml88d5e3c adds
global.setup.jsto wait for containers healthy status before running testsNote:
I have only made changes to
docker-compose-dev-wsl.yamlsince I can't make sure if the regulardocker-compose-dev.yamlworks after I modify it. I'm hoping @joshzcold you can add it and verify that it works on your machine.Although there is a go health checks library, I felt this was not needed here, but I copied the response format from their example