Websocket client and hub improvements #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Register clients to track them - Use buffered channel to stop clients - Make hub stop function public
Test Results27 tests 27 ✅ 54s ⏱️ Results for commit f446ed4. ♻️ This comment has been updated with latest results. |
joshzcold
requested changes
Feb 23, 2025
| @@ -50,8 +50,11 @@ func main() { | |||
| log.Panicf("Error: unable initalize store: %s", err) | |||
| } | |||
|
|
|||
| hub := api.NewHub() | |||
| go hub.Run() | |||
There was a problem hiding this comment.
Won't this make it so every client is connect to the same hub?
Im not sure I understand the purpose?
There was a problem hiding this comment.
Yes, totally my blunder, completely misunderstood here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some ideas to further improve websockets
added hub parameter to
ServerWsinclient.goand made the stop channel buffered. This should help with client tracking and stoppingrenamed
runtoRunforhub.goand added a non-blocking stop signal when unregistering clients, it should prevent client leaksinitialize hub in
ServerWsinmain.go,fix(api): prevent client leaks, improve hub|