Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support translation for login form placeholders #425

Merged
merged 15 commits into from
Dec 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/changelog/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

### Fixed

* Support translation for login form placeholders by [@hasansezertasan](https://github.com/hasansezertasan)
in [#425](https://github.com/jowilf/starlette-admin/pull/425)
* Update AuthMiddleware for Compatibility with Starlette >= 0.33 by [@jowilf](https://github.com/jowilf)
in [#427](https://github.com/jowilf/starlette-admin/pull/427)
* Fixes actions docstrings
Expand Down
4 changes: 2 additions & 2 deletions starlette_admin/templates/login.html
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h2 class="card-title text-center mb-4">{{ _("Login to your account") }}</h2>
<input type="text"
name="username"
class="form-control {% if form_errors and form_errors.has('username') %}is-invalid{% endif %}"
placeholder="Enter username"
placeholder="{{ _('Username') }}"
autocomplete="off"/>
{% if form_errors and form_errors.has('username') %}
<div class="invalid-feedback">{{ form_errors.msg('username') }}</div>
Expand All @@ -44,7 +44,7 @@ <h2 class="card-title text-center mb-4">{{ _("Login to your account") }}</h2>
<input type="password"
name="password"
class="form-control {% if form_errors and form_errors.has('password') %}is-invalid{% endif %}"
placeholder="Password"
placeholder="{{ _('Password') }}"
autocomplete="off"/>
{% if form_errors and form_errors.has('password') %}
<div class="invalid-feedback">{{ form_errors.msg('password') }}</div>
Expand Down