Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market Protections #12

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Market Protections #12

wants to merge 25 commits into from

Conversation

jfischoff
Copy link
Contributor

@jfischoff jfischoff commented Nov 4, 2022 •
edited
Loading

In light of the events taking place in different ecosystems and to further strengthen the security of our service/contract + royalties on the Cardano blockchain we are introducing two changes:

  • NFTs cannot be migrated to a non-royalty paying contract, sellers would need to delist manually.
  • All purchases require a JPG Store Signature to decrease the risk of contract-contract interaction vulnerabilities.

@jfischoff
tests pass again with V2 contract
19bd5cc
@jfischoff
add script reference utxos
24c07b1
@jfischoff
try using partial tx info
02c798d
@jfischoff
modifications to try to support raw
57745e9
@jfischoff
changes for profiling
f4317f6
@jfischoff
partial context ported over
f62780c
@jfischoff
compiling now with strictness fixes
e1a3966
@jfischoff
try different unionWith
347c9fa
@jfischoff
revert new unionWith
34ac404
@jfischoff
merge fixed partial context branch
e3e95b9
@jfischoff
better partial type
2963797
@jfischoff
got my structure in
fbfcdbe
@jfischoff
check point before merging upstream
b1ef7ee
@jfischoff
merged upstream
b862e91
@jfischoff
add market place signature check
c858d54
@jfischoff
compiles
8c9c89d
@jfischoff
sketch out marketplace payout method
0de772c
@jfischoff
Some test refactoring progress
f2a9c3c
@jfischoff
existing tests are updated and pass
9cfda1b
@jfischoff
add a test for the marketplace signature
4e2cf28
@jfischoff
can't cancel to anywhere test
91fab7f
@jfischoff
Add failing test to ensure marketplace is paid
52d9b7f
@jfischoff
fixed marketplace fee calculation so bad tests are failing
b3c9e69
@jfischoff
tests pass
6dfb173
@jfischoff
ensure market place fee is calculated correctly on offer
d6185b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jfischoff