Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typed.js URL #1970

Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix typed.js URL #1970

merged 1 commit into from
Feb 25, 2025

Conversation

thesosa
Copy link
Contributor

@thesosa thesosa commented Feb 16, 2025

Fix

Replaces the link to the typed.js script with a new one because the current one is broken and so the typing animation in the landing page does not start.

Fixes #1969

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thank you!

@wren
Copy link
Member

wren commented Feb 18, 2025

Note: The failing CI in this depends on #1971 to fix.

@wren wren merged commit 30c341e into jrnl-org:develop Feb 25, 2025
2 checks passed
@wren
Copy link
Member

wren commented Feb 25, 2025

@thesosa Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing animation in landing page is broken
2 participants