fix: output.publicPath validation is too strict (#93)

closes #88
js-dxtools · May 20, 2016 · ac24d6e · ac24d6e
1 parent 46c99a0
commit ac24d6e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/properties/output/index.js b/src/properties/output/index.js
@@ -4,7 +4,10 @@ import { notAbsolutePath, absolutePath, urlPart } from '../../types'
 export default Joi.object({
   filename: notAbsolutePath,
   path: absolutePath,
-  publicPath: urlPart,
+  publicPath: Joi.alternatives().try([
+    urlPart,
+    Joi.string().valid(''),
+  ]),
   chunkFilename: notAbsolutePath,
   sourceMapFilename: notAbsolutePath,
   devtoolModuleFilenameTemplate: [notAbsolutePath, Joi.func()],

diff --git a/src/properties/output/index.test.js b/src/properties/output/index.test.js
@@ -39,7 +39,8 @@ const validModuleConfigs = [
   { crossOriginLoading: 'anonymous' },
   // #17
   { hashDigestLength: 6 }, // undocumented
-
+  // #18
+  { publicPath: '' },
 ]
 
 const invalidModuleConfigs = [