-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Allow performance.hints in webpack config (#150)
* feat: Allow performance.hints in webpack config Webpack 2.1.0-beta.28 adds `performance.hints` (which take boolean values) as a way to enable/disable performance warnings. (The first performance warning is about bundle size.) * fix: Fix name of an import The test file for the `performance` property should import the test utils module using `utils` in lowercase but instead imported `Utils` in uppercase. This worked fine on my machine because my filesystem is case-insensitive but fails in Travis because its filesystem is case-sensitive.
- Loading branch information
1 parent
fd3b40d
commit fbfd616
Showing
3 changed files
with
18 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import Joi from 'joi' | ||
|
||
export default Joi.object({ | ||
hints: Joi.boolean(), | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import schema from './index' | ||
import { allValid } from '../../../test/utils' | ||
|
||
const validPerformanceConfigs = [ | ||
{ input: { hints: true } }, | ||
{ input: { hints: false } }, | ||
] | ||
|
||
describe('performance', () => { | ||
allValid(validPerformanceConfigs, schema) | ||
}) |