Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create model api #115

Merged
merged 17 commits into from
May 6, 2021
Merged

Create model api #115

merged 17 commits into from
May 6, 2021

Conversation

samihamdan
Copy link
Collaborator

One way to implement #114

@samihamdan samihamdan requested a review from fraimondo January 20, 2021 07:27
fraimondo
fraimondo requested changes Jan 20, 2021
View reviewed changes
@samihamdan samihamdan requested a review from fraimondo January 20, 2021 10:56
@samihamdan
Copy link
Collaborator Author

Added functionality to set model/pipeline params.
No custom checks on it, because it will throw the proper error anyways if someone tries to set smth wrong

@samihamdan samihamdan self-assigned this May 6, 2021
fraimondo
fraimondo requested changes May 6, 2021
View reviewed changes
fraimondo
fraimondo requested changes May 6, 2021
View reviewed changes
@samihamdan samihamdan merged commit 8651b0d into main May 6, 2021
@fraimondo fraimondo mentioned this pull request Jul 21, 2022
Closed
@fraimondo fraimondo deleted the create_model_api branch July 21, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fraimondo fraimondo fraimondo approved these changes

Assignees

@samihamdan samihamdan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samihamdan @fraimondo