Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Optimise step wrapping #274

Merged
merged 8 commits into from
Oct 17, 2024
Merged

[ENH]: Optimise step wrapping #274

merged 8 commits into from
Oct 17, 2024

Conversation

fraimondo
Copy link
Contributor

Currently, if a step does apply to anything different that "continuous", it will be wrapped in a column transformer.

This is unoptimal as there is an overhead (which also invoves joblib) when this happens.

This PR fixes that by really checking the apply_to of the step with the X_types of the data. If the step really applies to a subset of features, then it will wrapped in a column transformer.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (eac0462) to head (f42ed99).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   89.89%   89.93%   +0.04%     
==========================================
  Files          56       56              
  Lines        2483     2493      +10     
  Branches      504      443      -61     
==========================================
+ Hits         2232     2242      +10     
- Misses        164      165       +1     
+ Partials       87       86       -1     
Flag Coverage Δ
docs 100.00% <ø> (ø)
julearn 89.92% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
julearn/config.py 100.00% <100.00%> (ø)
julearn/inspect/_pipeline.py 100.00% <100.00%> (ø)
julearn/pipeline/pipeline_creator.py 86.95% <100.00%> (+0.48%) ⬆️
julearn/transformers/ju_column_transformer.py 93.18% <100.00%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

@fraimondo fraimondo marked this pull request as ready for review October 17, 2024 08:00
@fraimondo fraimondo requested a review from synchon October 17, 2024 08:02
Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the docs are failing, once fixed, good to go!

Copy link

github-actions bot commented Oct 17, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-17 09:45 UTC

@fraimondo fraimondo merged commit 36fb37a into main Oct 17, 2024
20 checks passed
@fraimondo fraimondo deleted the fix/wrap_trans branch October 17, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants