-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Optimise step wrapping #274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 89.89% 89.93% +0.04%
==========================================
Files 56 56
Lines 2483 2493 +10
Branches 504 443 -61
==========================================
+ Hits 2232 2242 +10
- Misses 164 165 +1
+ Partials 87 86 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the docs are failing, once fixed, good to go!
|
Currently, if a step does apply to anything different that
"continuous"
, it will be wrapped in a column transformer.This is unoptimal as there is an overhead (which also invoves joblib) when this happens.
This PR fixes that by really checking the
apply_to
of the step with theX_types
of the data. If the step really applies to a subset of features, then it will wrapped in a column transformer.