Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert order of CV so it runs the largest first #275

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Conversation

fraimondo
Copy link
Contributor

When the final model is expected, the CV iterator ads one more split that trains on all data.

This PR inverts the order, so the first split is the final model.

This has no impact on the results, but has an impact on compute time when masively parallelised (e.g. using htcondor).

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (d0fcf31) to head (ffca079).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files          56       56           
  Lines        2493     2493           
  Branches      443      443           
=======================================
  Hits         2242     2242           
  Misses        165      165           
  Partials       86       86           
Flag Coverage Δ
docs 100.00% <ø> (ø)
julearn 89.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
julearn/api.py 92.89% <100.00%> (ø)
julearn/model_selection/final_model_cv.py 100.00% <100.00%> (ø)

@fraimondo fraimondo marked this pull request as ready for review October 17, 2024 09:43
@fraimondo fraimondo requested a review from synchon October 17, 2024 09:43
Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have the version changes of pyproject.toml in a separate PR to keep things traceable?

Copy link

github-actions bot commented Oct 17, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-17 13:59 UTC

@fraimondo fraimondo requested a review from synchon October 17, 2024 13:40
@synchon synchon merged commit 2007273 into main Oct 17, 2024
16 checks passed
@synchon synchon deleted the fix/invert_cv_order branch October 17, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants