Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control parallel column transformer in filter columns #277

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

fraimondo
Copy link
Contributor

Use the same logic for the FilterColumns as for the JuColumnTransformer, avoiding parallel calls if not specified by the user.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.93%. Comparing base (f34d277) to head (f8b68fa).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files          56       56           
  Lines        2493     2494    +1     
  Branches      443      443           
=======================================
+ Hits         2242     2243    +1     
  Misses        165      165           
  Partials       86       86           
Flag Coverage Δ
docs 100.00% <ø> (ø)
julearn 89.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
julearn/transformers/dataframe/filter_columns.py 90.90% <100.00%> (+0.43%) ⬆️

@fraimondo fraimondo marked this pull request as ready for review October 21, 2024 13:08
Copy link

github-actions bot commented Oct 21, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-22 08:17 UTC

@fraimondo fraimondo requested a review from synchon October 21, 2024 16:20
@fraimondo fraimondo merged commit 6393826 into main Oct 22, 2024
20 checks passed
@fraimondo fraimondo deleted the enh/filter_parallel_control branch October 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants